feat: add borderCurve and pointerEvents style properties #228
Conversation
|
it needs this first facebook/react-native@a0800ff (types are now in react-native repo) |
| @@ -107,12 +111,12 @@ describe('createRestyleComponent', () => { | |||
| it('does not pass styling properties to the child', () => { | |||
| const {root} = render( | |||
| <ThemeProvider theme={theme}> | |||
| <Component opacity={0.5} pointerEvents="auto" /> | |||
| <Component opacity={0.5} removeClippedSubviews /> | |||
There was a problem hiding this comment.
Why was pointerEvents replaced by removeClippedSubviews?
There was a problem hiding this comment.
Because pointerEvents is now present in style since rn 0.71 so this test failed. I have used removeClippedSubview but I could choose another property (that is not a style one)
There was a problem hiding this comment.
React Native's borderCurve and pointerEvents don't seem to have been added to React Native's ViewStyle type. When clicking through ViewStyle on this line, borderCurve and pointerEvents are not included (see image below). This is causing the build failures. Do you know why they're not being included?
|
Yes, I added them in @types/react-native but now types are directly in react-native, a similar PR has been merged but related commits are not in react native 0.71.2. We have to wait a future version |
Description
see comment #188 (comment)
Checklist