Save theme memoization in a local WeakMap #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortmarek
force-pushed
the
fix/frozen-value
branch
from
97802b3 to
2c75b34
Compare
mattfrances
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When upgrading to
react-native-reanimatedto3.0.0, the app was crashing immediately upon opening with the following error:Turns out,
react-native-reanimatedfreezes objects that are transformed to shareable – recursively. This means thatthemewas frozen and subsequently also the memoziation map we save to the theme was, too.Instead of saving the memoziation directly inside the theme object, we can create a new WeakMap where the key is the theme itself and the value is the memoization map.
Reviewers’ hat-rack 🎩
react-native-reanimated3.0.0 -> it should not crashChecklist