Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all ruby-build http clients #36

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

rwstauner
Copy link
Contributor

@rwstauner rwstauner commented Feb 29, 2024

The http function doesn't support "-" as stdout when using the aria2c client.
It also only supports writing to a file in the current directory.

@rwstauner rwstauner force-pushed the rwstauner/http-get-stdout branch from 2e2deea to 68ea419 Compare February 29, 2024 21:50
The http function doesn't support "-" as stdout when using the aria2c client.
@rwstauner rwstauner force-pushed the rwstauner/http-get-stdout branch from 68ea419 to 3bab6e1 Compare February 29, 2024 22:18
@rwstauner rwstauner requested a review from nirvdrum February 29, 2024 22:24
Copy link
Contributor

@nirvdrum nirvdrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I've tried with aria2c, curl, and wget (using RUBY_BUILD_HTTP_CLIENT) and it now works with all of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants