Add support for server addons #454
Conversation
andyw8
force-pushed
the
andyw8/vinistock/server-architecture-exploration
branch
from
1ebb9c0
to
d749d1b
Compare
|
FYI @KaanOzkan |
| @@ -96,6 +96,14 @@ def initialize | |||
| raise InitializationError, @stderr.read | |||
| end | |||
|
|
|||
| sig { params(server_addon_path: String).void } | |||
| def register_server_addon(server_addon_path) | |||
There was a problem hiding this comment.
Why do we need both inherited and register_server_addon?
There was a problem hiding this comment.
🤔 perhaps we don't.... @vinistock ?
There was a problem hiding this comment.
Also I wanted to bring up for context that we need a way to limit who can use our addon. Right now we can do it in the addon while triggering register_server_addon.
There was a problem hiding this comment.
They run on different Ruby processes, so I'm not sure how we could combine theses two.
Also, why do we need to limit who uses the addon?
There was a problem hiding this comment.
I thought it wasn't necessary but now I see that inherited is only triggered through the manual require we do in the server so we also need register_server_addon.
Also, why do we need to limit who uses the addon?
We need to do some testing first on a partial rollout.
There was a problem hiding this comment.
We need to do some testing first on a partial rollout.
We can manage that on the Tapioca side though, right?
There was a problem hiding this comment.
Currently, there's no way to perform a partial rollout. But we could inform addons if experimental features are enabled so that they can decide whether to do something or not.
That would give you some control.
There was a problem hiding this comment.
As I said above, with this implementation, rollout can be controlled by the individual addons through the trigger of register_server_addon. It's not an issue.
| @@ -96,6 +96,14 @@ def initialize | |||
| raise InitializationError, @stderr.read | |||
| end | |||
|
|
|||
| sig { params(server_addon_path: String).void } | |||
| def register_server_addon(server_addon_path) | |||
There was a problem hiding this comment.
They run on different Ruby processes, so I'm not sure how we could combine theses two.
Also, why do we need to limit who uses the addon?
andyw8
force-pushed
the
andyw8/vinistock/server-architecture-exploration
branch
from
462564c
to
a248a32
Compare
Co-authored with @vinistock.
This is initially to support the Tapioca LSP.
There is some tricky logic involving two mutexes that was needed to ensure things are loaded in the correct order.