Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dynamic constant path names in document symbol #481

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Fix dynamic constant path names in document symbol #481

merged 1 commit into from
Oct 16, 2024

Conversation

vinistock
Copy link
Member

We need to always use the constant_name helper to get a constant path full name. If there are dynamic or missing parts, full_name raises.

@vinistock vinistock added the bugfix This PR fixes an existing bug label Oct 16, 2024
@vinistock vinistock self-assigned this Oct 16, 2024
@vinistock vinistock requested a review from a team as a code owner October 16, 2024 13:59
@vinistock vinistock merged commit d2441c7 into main Oct 16, 2024
28 checks passed
@vinistock vinistock deleted the vs-fix-dynamic-constant-path branch October 16, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyw8 andyw8 andyw8 approved these changes

@st0012 st0012 Awaiting requested review from st0012 st0012 is a code owner automatically assigned from Shopify/ruby-dx

Assignees

@vinistock vinistock

Labels
bugfix This PR fixes an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinistock @andyw8