Check for pending migrations when watcher is fired #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @vinistock and the rest of your teammates on |
vinistock
force-pushed
the
11-01-check_for_pending_migrations_when_watcher_is_fired
branch
from
ccc9cc0
to
1de4925
Compare
vinistock
force-pushed
the
11-01-add_support_for_checking_for_pending_migrations_and_running_them
branch
from
429fac9
to
dedae91
Compare
vinistock
force-pushed
the
11-01-check_for_pending_migrations_when_watcher_is_fired
branch
from
1de4925
to
0208974
Compare
vinistock
force-pushed
the
11-01-add_support_for_checking_for_pending_migrations_and_running_them
branch
from
dedae91
to
b26a4ca
Compare
vinistock
force-pushed
the
11-01-check_for_pending_migrations_when_watcher_is_fired
branch
3 times, most recently
from
e9d2887
to
32a4d5e
Compare
|
Perhaps we can also have it check for pending migrations when launched? |
andyw8
reviewed
Nov 1, 2024
andyw8
reviewed
Nov 1, 2024
vinistock
force-pushed
the
11-01-add_support_for_checking_for_pending_migrations_and_running_them
branch
from
b26a4ca
to
d9eb436
Compare
vinistock
force-pushed
the
11-01-check_for_pending_migrations_when_watcher_is_fired
branch
from
32a4d5e
to
14bd78a
Compare
|
Started checking after launching the runner client. |
vinistock
changed the base branch from
11-01-add_support_for_checking_for_pending_migrations_and_running_them
to
graphite-base/504
vinistock
force-pushed
the
graphite-base/504
branch
from
d9eb436
to
2a3558b
Compare
vinistock
force-pushed
the
11-01-check_for_pending_migrations_when_watcher_is_fired
branch
from
14bd78a
to
70583f7
Compare
vinistock
force-pushed
the
11-01-check_for_pending_migrations_when_watcher_is_fired
branch
from
70583f7
to
159c774
Compare
vinistock
force-pushed
the
11-01-check_for_pending_migrations_when_watcher_is_fired
branch
from
159c774
to
165dd54
Compare
andyw8
approved these changes
Nov 5, 2024
Merge activity
|
vinistock
deleted the
11-01-check_for_pending_migrations_when_watcher_is_fired
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for pending migrations, notify the user and offer to run them. The idea is that if any modifications are made to the
db/migratedirectory, we check if there are pending migrations.If there are, we show a dialog and offers to run them. If the user decides to do it, we then fire a request to the server to run the migrations.
Note: we only show the dialog if a migration is deleted or created, otherwise it can become really annoying when you are editing the migration you just created.