Add file open support for route lookup #2232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmcgibbon
force-pushed
the
lookup_route
branch
2 times, most recently
from
98482f0 to
0f25562
Compare
gmcgibbon
added
enhancement
vinistock
reviewed
Jul 4, 2024
To support mapping controller actions to routes in Shopify/ruby-lsp-rails#241.
vinistock
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To support mapping controller actions to routes in Shopify/ruby-lsp-rails#241.
Allows us to open files using a platform-agnostic command.
Implementation
Implements
rubyLsp.openFileusing a controller.Automated Tests
None. I didn't see any for similar commands, maybe I missed theem. Do I need these?
Manual Tests
Works with corresponding PR over on ruby-lsp-rails.