Prevent workspace dependencies from failing if there's no bundle #3655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
added
server
Graphite App
egiurleo
approved these changes
Jul 11, 2025
Contributor
egiurleo
left a comment
egiurleo
left a comment
There was a problem hiding this comment.
Speed running error fixes 😆
Merge activity
|
### Motivation The `workspace_dependencies` custom request may fail if there's no Gemfile. We need to handle that possibility. ### Implementation All we have to do is rescue the error raised by Bundler when there's no Gemfile.
graphite-app
bot
force-pushed
the
07-11-prevent_workspace_dependencies_from_failing_if_there_s_no_bundle
branch
from
40350fb to
290edfc
Compare
graphite-app
bot
deleted the
07-11-prevent_workspace_dependencies_from_failing_if_there_s_no_bundle
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
workspace_dependenciescustom request may fail if there's no Gemfile. We need to handle that possibility.Implementation
All we have to do is rescue the error raised by Bundler when there's no Gemfile.