Prevent relative require completion for unsaved files #3656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
added
bugfix
Graphite App
egiurleo
approved these changes
Jul 11, 2025
Merge activity
|
### Motivation If a user is typing a `require_relative` in an unsaved file, we have no way of providing completion since we don't know where the user intends to save the file and the path needs to be relative to that. This currently crashes the request, but we can simply protect the code from this and return empty completions. ### Implementation Started returning early if the `full_path` of the URI is `nil` (which means the file is unsaved and we don't know what the file system path is). ### Automated Tests Added a test that reproduces the same crash.
graphite-app
bot
force-pushed
the
07-11-prevent_relative_require_completion_for_unsaved_files
branch
from
8d2c871 to
ccfd63b
Compare
graphite-app
bot
deleted the
07-11-prevent_relative_require_completion_for_unsaved_files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If a user is typing a
require_relativein an unsaved file, we have no way of providing completion since we don't know where the user intends to save the file and the path needs to be relative to that.This currently crashes the request, but we can simply protect the code from this and return empty completions.
Implementation
Started returning early if the
full_pathof the URI isnil(which means the file is unsaved and we don't know what the file system path is).Automated Tests
Added a test that reproduces the same crash.