Account for module wrapping Minitest specs #3715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
added
bugfix
Graphite App
alexcrocha
approved these changes
Aug 15, 2025
Merge activity
|
### Motivation Closes #3712 When we find no test classes, we were considering the describe groups to start at index 1 in our stack of test groups. If you have a module wrapping those specs, that won't be true as there will be a corresponding `nil` entry in the stack (which we use to balance the stack). We need to search for what is actually the first index to account for this possibility. ### Implementation Started searching for what is the first spec group, rather than assuming that it's always the first one. I also moved our `in_spec_context?` check since we want to allow the `describe` to be discovered even if the nesting is not empty and we haven't yet found a spec group (which is what happens when there's only a top level module). ### Automated Tests Added a test that reproduces the scenario.
graphite-app
bot
force-pushed
the
08-15-account_for_module_wrapping_minitest_specs
branch
from
0d135ae to
514a20e
Compare
graphite-app
bot
deleted the
08-15-account_for_module_wrapping_minitest_specs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #3712
When we find no test classes, we were considering the describe groups to start at index 1 in our stack of test groups. If you have a module wrapping those specs, that won't be true as there will be a corresponding
nilentry in the stack (which we use to balance the stack).We need to search for what is actually the first index to account for this possibility.
Implementation
Started searching for what is the first spec group, rather than assuming that it's always the first one. I also moved our
in_spec_context?check since we want to allow thedescribeto be discovered even if the nesting is not empty and we haven't yet found a spec group (which is what happens when there's only a top level module).Automated Tests
Added a test that reproduces the scenario.