Ensure binmode and sync on LSP reporter socket #3820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
added
bugfix
Graphite App
alexcrocha
approved these changes
Nov 12, 2025
Merge activity
|
### Motivation I believe this will close #3760 Since we're using JSON RPC to communicate test results between server and extension, we have to turn on - binmode: so that Windows preserves the `\r\n\r\n` sequences that are the key request separators - sync: so that the content of the pipe is not buffered, but immediately flushed We already do this one very stdio we use and we forgot to do the same for the socket used for tests. ### Implementation Added `binmode` and `sync` to our LSP reporter socket. ### Automated Tests I believe that turning `binmode` on our fake test client would've been enough to catch this.
graphite-app
bot
force-pushed
the
11-11-ensure_binmode_and_sync_on_lsp_reporter_socket
branch
from
46e63e5 to
f226e90
Compare
graphite-app
bot
deleted the
11-11-ensure_binmode_and_sync_on_lsp_reporter_socket
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I believe this will close #3760
Since we're using JSON RPC to communicate test results between server and extension, we have to turn on
\r\n\r\nsequences that are the key request separatorsWe already do this one very stdio we use and we forgot to do the same for the socket used for tests.
Implementation
Added
binmodeandsyncto our LSP reporter socket.Automated Tests
I believe that turning
binmodeon our fake test client would've been enough to catch this.