Bump rubocop from 1.45.1 to 1.48.0 #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.45.1 to 1.48.0. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.45.1...v1.48.0) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/bundler/rubocop-1.48.0
branch
from
7f7be2a
to
239e50c
Compare
dependabot
bot
added
dependencies
github-actions
bot
added
the
config change
sambostock
approved these changes
Mar 7, 2023
There was a problem hiding this comment.
@rafaelfranca I've enabled a couple cops, if you want to sign off on them.
Comment on lines
+329
to
+330
| Metrics/CollectionLiteralLength: | ||
| Enabled: true |
There was a problem hiding this comment.
rubocop/rubocop#11584 (comment) summarizes why I created this cop and why I'd like to enable it. TL;DR: every time I've seen huge literals, there was a better approach.
Comment on lines
+469
to
+470
| Style/DirEmpty: | ||
| Enabled: true |
There was a problem hiding this comment.
These seem simple enough, so I went ahead and enabled them.
sambostock
force-pushed
the
dependabot/bundler/rubocop-1.48.0
branch
from
ba02bd8
to
eb0f70e
Compare
rafaelfranca
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps rubocop from 1.45.1 to 1.48.0.
Release notes
Sourced from rubocop's releases.
... (truncated)
Changelog
Sourced from rubocop's changelog.
... (truncated)
Commits
8d32826Cut 1.4836cc776Update Changelogaf8b5f9[Fix #11164] Suppress server mode message with -f json (#11668)8257ff2[Fix #11629] Add newStyle/FileEmptycopf23e487Cacheclassname_attribute_valuein junit formatter0499a58[Fix #11628] Add newStyle/DirEmptycopf982aa8[Fix #11663] Fix an incorrect autocorrect forStyle/BlockDelimitersd8f6765Merge pull request #11665 from fatkodima/registry-enabled-cop-name118542bMerge pull request #11638 from ydah/fix-lint_useless_access_modifier0d3c056Fix a false positive forLint/UselessAccessModifierwhen using same access ...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)