Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow test_ method names to violate snake_case #511

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

sambostock
Copy link
Contributor

@sambostock sambostock commented Mar 8, 2023

Tests are a use case where it is sometimes valuable to be able to violate the snake_case convention. For example

def test_GET_request_response_is_200_OK

@sambostock sambostock requested a review from a team as a code owner March 8, 2023 03:14
@github-actions github-actions bot added the config change Changes the Rubocop config by enabling, disabling, or reconfiguring one or many cops label Mar 8, 2023
Tests are a use case where it is sometimes valuable to be able to
violate the `snake_case` convention. For example

    def test_GET_request_response_is_200_OK
@sambostock sambostock force-pushed the allow-non-camel-case-test-names branch from bc9f808 to 1369448 Compare March 8, 2023 03:49
@sambostock sambostock merged commit ad60495 into main Mar 8, 2023
@sambostock sambostock deleted the allow-non-camel-case-test-names branch March 8, 2023 23:58
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems April 11, 2023 15:04 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config change Changes the Rubocop config by enabling, disabling, or reconfiguring one or many cops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants