Enable Style/IfWithBooleanLiteralBranches
#551
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find it really hard to find a reason for this rule to be disabled. It is very unlikely that in any situation a code like
is_admin = current_user.is_admin? ? true : false
will be more readable thanis_admin = is_admin
And even when the result is flipped like
is_admin = current_user.ordinary_user? ? false : true
an alternative -is_admin = !current_user.ordinary_user?
looks much more readable to meTo be honest I even disagree that we should have anything in
AllowedMethods
since I find!!value.nonzero?
to be much more readable thanvalue.nonzero? ? true : false