Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Hackdays method dispatch #3

Closed
wants to merge 14 commits into from
Closed

WIP Hackdays method dispatch #3

wants to merge 14 commits into from

Commits on Dec 11, 2019

  1. Let rb_call_cache also track method arity and the flags set on rb_cal… 

    …l_info to group those concerns into a single cache line as well
    @methodmissing
    methodmissing committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    54dafed View commit details
    Browse the repository at this point in the history

  2. Let the inline metchod cache miss branch due to method visibility cha… 

    …nge be unlikely (spurious is much more common from debug counters with Rails)
    @methodmissing
    methodmissing committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    6740477 View commit details
    Browse the repository at this point in the history

  3. Oust rb_call_info local from calccall

    @methodmissing
    methodmissing committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    e1cc922 View commit details
    Browse the repository at this point in the history

  4. Oust rb_call_info local from vm_call_iseq_setup_2

    @methodmissing
    methodmissing committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    4a58a1a View commit details
    Browse the repository at this point in the history

  5. Oust rb_call_info local from vm_call_method

    @methodmissing
    methodmissing committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    1d9dd58 View commit details
    Browse the repository at this point in the history

  6. Move call info to call cache backfill from vm_sendish and handle in c… 

    …ompile.c instead + handle loading bytecode as well
    @methodmissing
    methodmissing committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    a6e27ce View commit details
    Browse the repository at this point in the history

  7. Remove the call info local from vm_sendish

    @methodmissing
    methodmissing committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    5771478 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2019

  1. Remove another call info local from vm_call_iseq_setup_kwparm_nokwarg

    @methodmissing
    methodmissing committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    f0cbcbf View commit details
    Browse the repository at this point in the history

  2. Prefer unsigned short int for method info / cache flag and orig_argc … 

    …members
    @methodmissing
    methodmissing committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    754d542 View commit details
    Browse the repository at this point in the history

  3. Replace the method definition member with method ID instead and check… 

    … for refinement by new VM_CALL_REFINED instead
    @methodmissing
    methodmissing committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    62c27ee View commit details
    Browse the repository at this point in the history

  4. Prefer an inverse VM_CALL_UNREFINED flag instead and plugin method me… 

    …thod ID from the call cache into dispatch helpers
    @methodmissing
    methodmissing committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    73c819f View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2019

  1. Also cover a few remaining edge cases of flag, orig_argc and mid not … 

    …properly set on the call cache
    @methodmissing
    methodmissing committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    3edf237 View commit details
    Browse the repository at this point in the history

  2. Also let vm_caller_setup_arg_block prefer the call cache

    @methodmissing
    methodmissing committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    2766293 View commit details
    Browse the repository at this point in the history

  3. Remove spurious rb_call_info* argument from CALLER_REMOVE_EMPTY_KW_SPLAT

    @methodmissing
    methodmissing committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    2cddcda View commit details
    Browse the repository at this point in the history