feat: use Nokogiri's HUGE parse option #16
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In sparklemotion/nokogiri#2865, which upgrades the latest libxml2 release, I started seeing failures that seem related to the larges sizes of the valgrind output files generated by Nokogiri's test suite:
I haven't dug in too much as to why libxml2 2.11.0 is complaining about this, but a lot of the buffering code got rewritten. See the release notes for more information, but the work is being described as:
In any case, setting the
HUGE
parse option will avoid these errors, at the cost of a slight performance tradeoff.