Automatically detect Ruby native extensions #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$LOADED_FEATURES is now automatically communicated from the spawned process back into the main ruby_memcheck process which allows ruby_memcheck to automatically detect which binaries are native extensions and allow ruby_memcheck to work for multiple native extensions.
peterzhu2118
force-pushed
the
pz-auto-detect-binary
branch
from
8083b1d to
60dd673
Compare
Ruby 2.7 is EOL.
peterzhu2118
force-pushed
the
pz-auto-detect-binary
branch
from
d9ff116 to
3c189a1
Compare
This might fix some flaky tests because Valgrind may be combining functions in different binaries witht he same name.
peterzhu2118
force-pushed
the
pz-auto-detect-binary
branch
from
b379e21 to
1749394
Compare
We don't need the binary_name anymore, so the call to RubyMemcheck.config is optional.
peterzhu2118
force-pushed
the
pz-auto-detect-binary
branch
from
625c960 to
d415e82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$LOADED_FEATURES is now automatically communicated from the spawned process back into the main ruby_memcheck process which allows ruby_memcheck to automatically detect which binaries are native extensions and allow ruby_memcheck to work for multiple native extensions.