Version the graph examples

[nirvdrum]

This is a fixed branch for #84. I had merged that PR already before realizing that I lost the Ruby graphs for GraalVM 21.2.0. Since those cannot be regenerated without a patched Graal, we want to retain the originals. I reverted the PR on main and reworked the branch. This PR supplants #84 (see original for more context).

[rwstauner]

I'd write this as

Suggested change

	EXAMPLES_DIR = File.expand_path("#{__dir__}/../examples", __dir__)
	EXAMPLES_DIR = File.expand_path("../examples", __dir__)

As is, I think the second arg will be unused

[nirvdrum]

Interesting. I didn't even realize there was a second argument.

[rwstauner]

There's quite a bit more functionality duplicated across the methods that you could move to this function.

Suggested change

	def run_command(graalvm, args, options = {})
	if VERBOSE
	log(graalvm, " Command: #{args.join(" ")}")
	end
	IO.popen(args, options)
	end
	def run_java(graalvm, bin, dump_level, *args)
	FileUtils.rm_rf("./graal_dumps")
	pipe = run_command(graalvm, [
	"#{bin}/java", \
	"-XX:+PrintCompilation",
	"-Dgraal.PrintGraphWithSchedule=true",
	"-Dgraal.Dump=:#{dump_level}",
	] + args)
	yield pipe
	sleep(3)
	Process.kill("KILL", pipe.pid)
	Process.wait(pipe.pid)
	end
	def run_js(graalvm, bin, *args)
	FileUtils.rm_rf("graal_dumps")
	pipe = run_command(
	graalvm,
	[
	"#{bin}/node",
	"--experimental-options",
	"--engine.CompileOnly=fib",
	"--engine.TraceCompilation",
	"--engine.MultiTier=false",
	graalvm.options_version == 1 ? "--engine.Inlining=false" : "--compiler.Inlining=false",
	"--vm.Dgraal.Dump=Truffle:1",
	] + args,
	{ err: [:child, :out] },
	)
	yield pipe
	sleep(3)
	Process.kill("KILL", pipe.pid)
	Process.wait(pipe.pid)
	end
	def run_ruby(graalvm, bin, *args)
	FileUtils.rm_rf("./graal_dumps")
	pipe = run_command(
	graalvm,
	[
	"#{bin}/ruby",
	"--jvm",
	"--experimental-options",
	"--engine.TraceCompilation",
	graalvm.options_version == 1 ? "--engine.NodeSourcePositions" : "--compiler.NodeSourcePositions",
	"--engine.MultiTier=false",
	"--vm.Dgraal.Dump=Truffle:1",
	] + args,
	{ err: [:child, :out] },
	)
	yield pipe
	sleep(3)
	Process.kill("KILL", pipe.pid)
	Process.wait(pipe.pid)
	end
	def run_command(graalvm, args, options = {})
	if VERBOSE
	log(graalvm, " Command: #{args.join(" ")}")
	end
	FileUtils.rm_rf("./graal_dumps")
	pipe = IO.popen(args, options)
	yield pipe
	sleep(3)
	Process.kill("KILL", pipe.pid)
	Process.wait(pipe.pid)
	end
	def run_java(graalvm, bin, dump_level, *args)
	run_command(graalvm, [
	"#{bin}/java", \
	"-XX:+PrintCompilation",
	"-Dgraal.PrintGraphWithSchedule=true",
	"-Dgraal.Dump=:#{dump_level}",
	] + args)
	end
	def run_js(graalvm, bin, *args)
	run_command(
	graalvm,
	[
	"#{bin}/node",
	"--experimental-options",
	"--engine.CompileOnly=fib",
	"--engine.TraceCompilation",
	"--engine.MultiTier=false",
	graalvm.options_version == 1 ? "--engine.Inlining=false" : "--compiler.Inlining=false",
	"--vm.Dgraal.Dump=Truffle:1",
	] + args,
	{ err: [:child, :out] },
	)
	end
	def run_ruby(graalvm, bin, *args)
	run_command(
	graalvm,
	[
	"#{bin}/ruby",
	"--jvm",
	"--experimental-options",
	"--engine.TraceCompilation",
	graalvm.options_version == 1 ? "--engine.NodeSourcePositions" : "--compiler.NodeSourcePositions",
	"--engine.MultiTier=false",
	"--vm.Dgraal.Dump=Truffle:1",
	] + args,
	{ err: [:child, :out] },
	)
	end

[rwstauner]

Also noticed that { err: [:child, :out] }, is only used for js and ruby (not java).
We're currently discarding stdout so I think the only difference is that the java command's stderr would be printed to console.

[nirvdrum]

I'm okay with the duplication. All I wanted was a way to log the command easily. I'm already a bit uneasy with the multiple levels required to execute a command. I think the simplicity of the original bash-like implementation was a lot easier to follow.

[rwstauner]

A couple of notes but looks fine.