This repository was archived by the owner on Apr 11, 2024. It is now read-only.
Adds support for read-only attributes to serialize #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomarg
reviewed
May 4, 2022
src/base-rest-resource.ts
Outdated
| ) { | ||
| return acc; | ||
| } | ||
|
|
||
| if (attribute in HAS_MANY && value) { | ||
| acc[attribute] = value.reduce( | ||
| (attrAcc: Body, entry: Base) => | ||
| attrAcc.concat(entry.serialize ? entry.serialize() : entry), | ||
| attrAcc.concat(entry.serialize ? entry.serialize(saving) : entry), |
There was a problem hiding this comment.
We should probably also do the thing here where if !entry.serialize, we create a new instance so that we can serialize it.
mkevinosullivan
force-pushed
the
kos/add_saving_param_to_serialize
branch
from
73ff445 to
4512467
Compare
Previously, serialize excluded read-only attributes, since it was assumed it was just being used by save method. Now, default is that serialize returns all attributes, and an optional (saving=)true parameter will exclude them when used inside save method.
mkevinosullivan
force-pushed
the
kos/add_saving_param_to_serialize
branch
from
082a2c1 to
08815d1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
To align the behaviour of
serializewith that of the Rubyto_hashmethod, as updated by Shopify/shopify-api-ruby#941WHAT is this pull request doing?
Previously,
serializeexcluded read-only attributes, since it was assumed it was just being used bysavemethod.Now, default is that
serializereturns all attributes, and an optional (saving=)trueparameter will exclude them when used insidesavemethod.Type of change
Checklist