Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the type of ShopifyAPI::Variant#weight Integer? #931

Closed
koshigoe opened this issue Apr 12, 2022 · 1 comment · Fixed by #935
Closed

Is the type of ShopifyAPI::Variant#weight Integer? #931

koshigoe opened this issue Apr 12, 2022 · 1 comment · Fixed by #935

Comments

@koshigoe
Copy link

Issue summary

The ShopifyAPI::Variant defines weight as Integer.

https://github.com/Shopify/shopify_api/blob/1d76f06f623812ff06c57e1523da275f3e889583/lib/shopify_api/rest/resources/2022_01/variant.rb#L39

But, in the API reference specified weight as Float.

image

image

Expected behavior

The type of ShopifyAPI::Variant#weight should be Float?

Actual behavior

The type of ShopifyAPI::Variant#weight is Integer.
Is this correct?

Specifications

  • shopify_api version: 10.0.2
  • Shopify API version used 2022-01
@paulomarg
Copy link
Contributor

Great catch, I'm pretty sure it should indeed be a Float. We'll look into it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants