Fixes issue 931, weight of variant should be float #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teddyhwang
approved these changes
Apr 20, 2022
Example in Shopify/shopify had an integer (100) for weigth thus wrapper generation inferred Integer. Changed the example to 100.0 to correct it in the generated wrappers.
mkevinosullivan
force-pushed
the
kos/make_weight_of_variant_float
branch
from
e330929 to
a456891
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #931
Example in Shopify/shopify had an integer (100) for weight thus wrapper generation inferred Integer. Changed the example to 100.0 to correct it in the generated wrappers.
How has this been tested?
Tests re-run, and changed file inspected for correct change.
Checklist: