Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in session_storage.md #1044

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Fix typo in session_storage.md #1044

merged 1 commit into from
Oct 20, 2022

Conversation

JohnnyKei
Copy link
Contributor

Description

session storage document is wrong
ShopifyAPI::Auth::SessionStore is not exist.

How has this been tested?

no change codebase

Checklist:

  • My commit message follow the pattern described in here
  • I have performed a self-review of my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the project documentation.
  • I have added a changelog line.

@JohnnyKei JohnnyKei requested a review from a team as a code owner October 20, 2022 13:21
klenotiw
klenotiw approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@klenotiw klenotiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that!

@klenotiw klenotiw merged commit 493f201 into Shopify:main Oct 20, 2022
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems October 20, 2022 14:28 Inactive
@ClaytonPassmore ClaytonPassmore mentioned this pull request Feb 22, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klenotiw klenotiw klenotiw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnnyKei @klenotiw