-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Adding FulfillmentOrder, FulfillmentRequest, CancellationRequest, AssignedFulfillmentOrder resources/filters #622
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense nested under the order
resource, like you have it
Fixture mostly looks good; I think everything is coherent (like, proper request_status for an FO with an ApiFulfillmentService). The value of IDs doesn't really matter, right?
3640f95
to
d7a2108
Compare
d7a2108
to
7a021a6
Compare
…ation_request to FulfillmentOrder resource
7a021a6
to
5366683
Compare
Adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont really have any knowledge about fulfillment however the code looks good
end | ||
end | ||
|
||
# context "#with_assigned_status" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is up with this commented out code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was experimenting with how to organize assigned_fulfillment_orders either as a resource type matching the implemented endpoints or as methods on a fulfillment_orders resource from the client's perspective.
This can be deleted put into an assigned_fulfillment_orders_test.
Hey @karmakaze, are you still working on this one? |
@stevelounsbury Sorry I haven't had time to get back to Fulfillment Orders work, just finishing up the last of the Priority-1 Pickup In-store issues. |
Issue #211513 make shopify_api FO compatible
Add
/orders/:order_id/fulfillment_orders
resourceReviewers please carefully check the
move
endpoint test in particular for form of request query/body and response.