-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inventory param patch fix #731
Conversation
👋 We noticed that this PR either modifies or introduces a link into help.shopify.com with a hardcoded locale. Help can automatically detect the locale from the HTTP Accept-Language header and redirect the user to the appropriate language. For more info, check this out in the Home repo README: https://github.com/shopify/help#content-files |
This is great however it seems there is still a legitimate test failure and you need to sign the CLA |
👋 We noticed that this PR either modifies or introduces a link into help.shopify.com with a hardcoded locale. Help can automatically detect the locale from the HTTP Accept-Language header and redirect the user to the appropriate language. For more info, check this out in the Help repo README: https://github.com/Shopify/help#locale-when-linking-into-help |
Sorry, just copied the tests from 9.0.3 version but they required some changes to work, fixed. |
Can we push this out into a version onto ruby gems? |
This is a duplicate of #655 but with the issue fixed, I posted the fix on that thread but no one paid attention for so long.