Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inventory param patch fix #731

Merged
merged 8 commits into from
May 15, 2020
Merged

Conversation

marschattha
Copy link
Contributor

This is a duplicate of #655 but with the issue fixed, I posted the fix on that thread but no one paid attention for so long.

@marschattha marschattha requested a review from a team as a code owner May 14, 2020 00:07
@CautionTapeBot
Copy link

👋 We noticed that this PR either modifies or introduces a link into help.shopify.com with a hardcoded locale. Help can automatically detect the locale from the HTTP Accept-Language header and redirect the user to the appropriate language.

Should you absolutely need to decide the language to be displayed, please use the locale query parameter.

Please consider updating the offending content.

For more info, check this out in the Home repo README: https://github.com/shopify/help#content-files

Find us at #docs :)

cc: @Shopify/docs-dev

@ghost ghost added the cla-needed label May 14, 2020
@tanema
Copy link
Contributor

tanema commented May 14, 2020

This is great however it seems there is still a legitimate test failure and you need to sign the CLA

@CautionTapeBot
Copy link

👋 We noticed that this PR either modifies or introduces a link into help.shopify.com with a hardcoded locale. Help can automatically detect the locale from the HTTP Accept-Language header and redirect the user to the appropriate language.

Should you absolutely need to decide the language to be displayed, please use the locale query parameter.

Please consider updating the offending content.

For more info, check this out in the Help repo README: https://github.com/Shopify/help#locale-when-linking-into-help

Find us at #docs :)

cc: @Shopify/self-help-dev @Shopify/intl-export-country-fit

@ghost ghost removed the cla-needed label May 14, 2020
@marschattha
Copy link
Contributor Author

This is great however it seems there is still a legitimate test failure and you need to sign the CLA

Sorry, just copied the tests from 9.0.3 version but they required some changes to work, fixed.

@tanema tanema merged commit 2565e7d into Shopify:master May 15, 2020
@marschattha
Copy link
Contributor Author

Can we push this out into a version onto ruby gems?
The deadline for removal of inventory_quantity params is coming soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants