Add ESM support for .mjs files in the nextjs config #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested, and it works! Thanks for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
In
shopify/quilt, we updated our package builds to provide an ESM build for consumers. This provides apps with more tree-shakable builds resulting in smaller production builds. Internally, our tooling is already configured to support these builds, though this boilerplate app isn't (see Shopify/quilt#1722).Fixes Shopify/quilt#1722
WHAT is this pull request doing?
Adding out of the box support for ESM (
.mjsfiles) libraries (Packages living inshopify/quilt)