Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

Support Rails 7 #1998

Merged
merged 3 commits into from
Feb 3, 2022
Merged

Support Rails 7 #1998

merged 3 commits into from
Feb 3, 2022

Conversation

gonzaloriestra
Copy link
Contributor

@gonzaloriestra gonzaloriestra commented Jan 31, 2022

WHY are these changes introduced?

Fixes #1813

WHAT is this pull request doing?

How to test your changes?

  1. Ensure you have Rails 7 (rails -v)
  2. shopify app create rails --name rails7app
  3. cd rails7app && shopify app serve

Update checklist

  • I've added a CHANGELOG entry for this PR (if the change is public-facing)
  • I've considered possible cross-platform impacts (Mac, Linux, Windows).
  • I've left the version number as is (we'll handle incrementing this when releasing).
  • I've included any post-release steps in the section above.

@gonzaloriestra gonzaloriestra marked this pull request as ready for review February 2, 2022 11:55
@gonzaloriestra gonzaloriestra requested review from a team, jesalerno84 and amcaplan and removed request for a team February 2, 2022 11:55
Copy link
Contributor

@amcaplan amcaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it locally and it seems to work. Thanks for working through this!

@gonzaloriestra gonzaloriestra merged commit c0c5a8e into main Feb 3, 2022
@gonzaloriestra gonzaloriestra deleted the rails7 branch February 3, 2022 15:24
@pepicrft pepicrft mentioned this pull request Feb 7, 2022
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems February 7, 2022 17:18 Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shopify app create rails w/ Rails 7 fails
2 participants