[ feature ] Update theme pull/push --only option to accept multiple patterns

[kilgore5]

WHY are these changes introduced?

After #1892, users can use the --only arg to "include" only certain files when using theme pull/push, but only one option pattern is accepted (see comment #1892 (comment))

This PR updates the --only option to allow it to be used multiple times, similarly to how the --ignore option behaves. E.g.
shopify theme pull -o 'templates/*.json' -o 'config/settings_data.json'

WHAT is this pull request doing?

This PR updates the ShopifyCLI::Theme::IncludeFilter to allow for multiple patterns to function similarly to how ShopifyCLI::Theme::IgnoreFilter already does.

How to test your changes?

empty-ish theme repo

$ ls

pull templates and config files

$ SHOPIFY_CLI_STACKTRACE=1 shopify theme pull -d -n -o 'templates/*.json' -o 'config/*.json'
⭑ You are running a development version of the CLI at:
  ~/shopify-cli-kilgore5/bin/shopify

┏━━ Pulling theme files from Development (5de3a3) (#123163869322) on sections-preview.myshopify.com 
┃                                                                                                           100%
┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ (0.79s) ━━

see expected files in config and templates directories

$ ls
config		templates

Post-release steps

• This is not yet done (separate PR perhaps), but it may be useful to update the theme pull/push command help text to note that --ignore and --include options can be used multiple times.
• update the theme pull/ push docs to document the --ignore --include option (https://shopify.dev/themes/tools/cli/theme-commands#push, https://shopify.dev/themes/tools/cli/theme-commands#pull)

Update checklist

• I've added a CHANGELOG entry for this PR (if the change is public-facing)
• I've considered possible cross-platform impacts (Mac, Linux, Windows).
• I've left the version number as is (we'll handle incrementing this when releasing).
• I've included any post-release steps in the section above.

[macournoyer]

Awesome! Thanks a lot for this @kilgore5 🙏

[karreiro]

Thank you, @kilgore5! Great stuff 🚀

[karreiro]

@kilgore5 regarding the post-release steps you've mentioned:

• +1 for improving the theme pull/push commands help text to note that --ignore and --include options may be used multiple times 🚀
• about the--ignore option, I believe it's already documented here: https://shopify.dev/themes/tools/cli/theme-commands#push, https://shopify.dev/themes/tools/cli/theme-commands#pull. Am I missing something? :)

Thanks again for the excellent PR!

[kilgore5]

Thank you very much for reviewing @macournoyer @karreiro !

@karreiro re: the post-deploy steps...

• stab at updating the help commands Improve theme pull/push help messages: indicate multiple only/ignore flags are allowed #2025
• I mistyped and should have clarified. I meant that the --only flag is not documented
  e.g. https://shopify.dev/themes/tools/cli/theme-commands#pull

[karreiro]

Thank you for the PR and the clarification, @kilgore5! 🚀

The docs team is taking care of updating the --only option on https://shopify.dev (for pull and push), so we may expect it there soon :)

[AdamDemirel]

Can confirm that this was also an issue for me if specifying multiple --ignore flags. If you use 3 --ignores and log the ignore_pattnerns here: https://github.com/Shopify/shopify-cli/blob/main/lib/project_types/theme/commands/push.rb#L35 You will see that it's getting the first ignore 3 times.

Example: