Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

Template improvements II #2004

Merged
merged 9 commits into from
Feb 7, 2022
Merged

Template improvements II #2004

merged 9 commits into from
Feb 7, 2022

Conversation

amcaplan
Copy link
Contributor

@amcaplan amcaplan commented Feb 2, 2022

WHY are these changes introduced?

The bug issue template is still a bit rough around the edges, here are some clear improvements.

WHAT is this pull request doing?

Improving the UX of the bug issue template

How to test your changes?

In the console, try:

begin
  invalidcommand
rescue => e
  ShopifyCLI::GitHub::IssueURLGenerator.error_url(e)
end

and see the stacktrace included as a param.

Screen Shot 2022-02-07 at 14 44 13

Update checklist

  • I've added a CHANGELOG entry for this PR (if the change is public-facing)
  • I've considered possible cross-platform impacts (Mac, Linux, Windows).
  • I've left the version number as is (we'll handle incrementing this when releasing).

@amcaplan amcaplan requested review from a team, pepicrft and hannachen and removed request for a team February 2, 2022 10:43
@amcaplan amcaplan changed the title Template improvements ii Template improvements II Feb 2, 2022
@amcaplan amcaplan force-pushed the template-improvements-ii branch 4 times, most recently from 1aebcde to 27208a4 Compare February 2, 2022 10:53
CHANGELOG.md Outdated
Comment on lines 13 to 14
* [#2001](https://github.com/Shopify/shopify-cli/pull/2001): Improve Bug Issue Template
* [#2004](https://github.com/Shopify/shopify-cli/pull/2004): Template improvements II
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't include these changes as they are not much relevant for the CLI users, arent' they?

Suggested change
* [#2001](https://github.com/Shopify/shopify-cli/pull/2001): Improve Bug Issue Template
* [#2004](https://github.com/Shopify/shopify-cli/pull/2004): Template improvements II

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They include changes to URL generator which is a user-facing change. @pepicrft, care to opine?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we surface improvements through the CLI I think it justifies an entry in the CHANGELOG. It'd have been different if the change was only in the template.

@amcaplan amcaplan merged commit e4c9112 into main Feb 7, 2022
@amcaplan amcaplan deleted the template-improvements-ii branch February 7, 2022 16:24
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems February 7, 2022 17:18 Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants