This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 202
+24
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amcaplan
requested review from
a team,
pepicrft and
hannachen
and removed request for
a team
February 2, 2022 10:43
amcaplan
force-pushed
the
template-improvements-ii
branch
4 times, most recently
from
February 2, 2022 10:53
1aebcde
to
27208a4
Compare
It doesn't solve for Windows, but something is better than nothing. Windows users should just see a blank field.
amcaplan
force-pushed
the
template-improvements-ii
branch
from
February 7, 2022 12:38
27208a4
to
a4b87b2
Compare
pepicrft
approved these changes
Feb 7, 2022
pepicrft
approved these changes
Feb 7, 2022
CHANGELOG.md
Outdated
Comment on lines
13
to
14
* [#2001](https://github.com/Shopify/shopify-cli/pull/2001): Improve Bug Issue Template | ||
* [#2004](https://github.com/Shopify/shopify-cli/pull/2004): Template improvements II |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't include these changes as they are not much relevant for the CLI users, arent' they?
Suggested change
* [#2001](https://github.com/Shopify/shopify-cli/pull/2001): Improve Bug Issue Template | |
* [#2004](https://github.com/Shopify/shopify-cli/pull/2004): Template improvements II |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They include changes to URL generator which is a user-facing change. @pepicrft, care to opine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we surface improvements through the CLI I think it justifies an entry in the CHANGELOG. It'd have been different if the change was only in the template.
amcaplan
force-pushed
the
template-improvements-ii
branch
from
February 7, 2022 16:23
cf85379
to
9de42c8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The bug issue template is still a bit rough around the edges, here are some clear improvements.
WHAT is this pull request doing?
Improving the UX of the bug issue template
How to test your changes?
In the console, try:
and see the stacktrace included as a param.
Update checklist