This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
Fix theme serve to accept parameters with multiple values
#2034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karreiro
requested review from
macournoyer,
a team,
pepicrft and
molly-yu
and removed request for
a team
karreiro
changed the title
theme serve to accept parameters with multiple values
Closed
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
When users open URLs with multiple occurrences of the same parameter (
?param=A¶m=B), they lose one of the values (AorB).WHAT is this pull request doing?
This PR changes the proxy to no longer convert query parameters into a hash map so users do not lose values anymore.
How to test your changes?
shopify theme serveBefore this PR
After this PR
Post-release steps
None.
Update checklist