This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 202
Improve --only
/--ignore
parameters on Theme pull
/push
commands to work without quotes
#2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karreiro
requested review from
macournoyer,
a team,
gonzaloriestra and
molly-yu
and removed request for
a team
February 16, 2022 16:57
2 tasks
macournoyer
approved these changes
Feb 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL about custom conversions!
kilgore5
reviewed
Feb 17, 2022
5 tasks
…s to work without quotes
- Improve `IncludeFilter` to support the `root` parameter
@karreiro Awesome, thanks! |
This was referenced Feb 25, 2022
kilgore5
pushed a commit
to kilgore5/shopify-cli
that referenced
this pull request
Mar 2, 2022
After Shopify#2066, specifying multiple flags stopped working, but specifying multiple patterns for one flag is working so easiest I think to just change the documentation to indicate how the options should be used
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The
theme push
command doesn't work as expected when partners use glob parameters like this:shopify theme push -d --only layout/*
. However, it works when they run the same command with quotesshopify theme push -d --only "layout/*"
.WHAT is this pull request doing?
Here's what happens from the
ShopifyCLI::Options
perspective when partners run the commands mentioned above:This PR addresses this issue by relying on custom conversions to handle glob values in the
Theme::Command::Pull
andTheme::Command::Push
classes.How to test your changes?
layout
directoryshopify theme push -d --only layout/*
(without quotes)--only
parameter works as expectedBefore this PR
After this PR
Post-release steps
The documentation of
--only
and--ignore
may mention that users can pass parameters with or without quotes.Update checklist