This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
Improve shopify theme package
to include the release-notes.md
file
#2103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The
release-notes.md
file is excluded when partners runshopify theme package
. However, that file is a new requirement to support the Shopify theme update feature.WHAT is this pull request doing?
This PR changes the
Theme::Command::Package
class to include therelease-notes.md
file in the list of zipped assets.Nitpick, but I've also changed the test to fail if something changes in the list of zipped assets.
How to test your changes?
shopify-dev theme package
in a theme directory with arelease-notes.md
filerelease-notes.md
file is no longer excludedPost-release steps
None.
Update checklist