Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

Improve shopify theme package to include the release-notes.md file #2103

Merged
merged 3 commits into from
Mar 7, 2022

Conversation

karreiro
Copy link
Contributor

@karreiro karreiro commented Mar 1, 2022

WHY are these changes introduced?

The release-notes.md file is excluded when partners run shopify theme package. However, that file is a new requirement to support the Shopify theme update feature.

WHAT is this pull request doing?

This PR changes the Theme::Command::Package class to include the release-notes.md file in the list of zipped assets.

Nitpick, but I've also changed the test to fail if something changes in the list of zipped assets.

How to test your changes?

  • Run shopify-dev theme package in a theme directory with a release-notes.md file
  • Unzip the file created by the previous step
  • Notice that the release-notes.md file is no longer excluded

demo

Post-release steps

None.

Update checklist

  • I've added a CHANGELOG entry for this PR (if the change is public-facing)
  • I've considered possible cross-platform impacts (Mac, Linux, Windows).
  • I've left the version number as is (we'll handle incrementing this when releasing).
  • I've included any post-release steps in the section above.

@karreiro karreiro requested review from macournoyer, a team, pepicrft and gonzaloriestra and removed request for a team March 1, 2022 16:23
@karreiro karreiro linked an issue Mar 1, 2022 that may be closed by this pull request
@karreiro karreiro merged commit 9e86e31 into main Mar 7, 2022
@karreiro karreiro deleted the fix-2029 branch March 7, 2022 16:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: theme package - include release-notes.md
2 participants