Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add method that calls register_all in api #1743

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Conversation

nelsonwittwer
Copy link
Contributor

What this PR does

Fixes #1719

When we refactored webhook subscription manager we failed to call the method that registers all the topics in the registry :(

Reviewer's guide to testing

Things to focus on

Checklist

Before submitting the PR, please consider if any of the following are needed:

  • Update CHANGELOG.md if the changes would impact users
  • Update README.md, if appropriate.
  • Update any relevant pages in /docs, if necessary
  • For security fixes, the Disclosure Policy must be followed.

@nelsonwittwer nelsonwittwer requested a review from a team as a code owner October 28, 2023 14:45
Copy link
Contributor

@paulomarg paulomarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@nelsonwittwer nelsonwittwer force-pushed the nw/recreate_webhooks_bug branch from d6fd34e to 340c98b Compare October 30, 2023 15:07
@nelsonwittwer nelsonwittwer merged commit 40aaa60 into main Oct 31, 2023
@nelsonwittwer nelsonwittwer deleted the nw/recreate_webhooks_bug branch October 31, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mandatory webhooks fail to create
2 participants