Start reporting errors from the translator #318
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
First step to #309
I'd like to approach this task with these steps:
prism_regression/error_recovery/
withtestdata/parser/error_recovery/
and try to enrich/calibrate our error reporting.error: Hint:
but only real syntax errorserror: Hint
With that in mind, in this PR:
error_recovery
folder to host error related fixture files as wellerror_recovery/assign
without converting it toerror_recovery_assign
(can't easily be done intasks.json
), I updatedtest/prism_location_test.bzl
tooTranslator::reportError
function and updated thePM_MISSING_NODE
case to start reporting basic errors when parsing invalid Ruby code, which starts withassign.rb
Test plan
See included automated tests.