Skip to content
This repository was archived by the owner on Nov 15, 2024. It is now read-only.

Loading all the plugins when creating the UI #4

Merged
pfryerdavis merged 1 commit into from
Jan 11, 2019
Merged

Loading all the plugins when creating the UI #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions history/src/main/scala/org/apache/spark/deploy/history/SimpleFsHistoryProvider.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,8 @@ private[history] class SimpleFsHistoryProvider(conf: SparkConf, clock: Clock)
attemptInfo.info.startTime.getTime(),
attemptInfo.info.appSparkVersion
)

loadPlugins().foreach(_.setupUI(ui))

LoadedAppUI(ui)
})
})
Expand All @@ -141,7 +142,6 @@ private[history] class SimpleFsHistoryProvider(conf: SparkConf, clock: Clock)
// actually read, we may never refresh the app. FileStatus is guaranteed to be static
// after it's created, so we get a file size that is no bigger than what is actually read.
Utils.tryWithResource(EventLoggingListener.openEventLog(logPath, fs)) { in =>
logInfo("Trying to replay bus: $isCompleted, $eventsFilter")
Copy link

@andrewdryder andrewdryder Jan 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove?

Copy link
Author

@pfryerdavis pfryerdavis Jan 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this as a debug log and forgot to remove it.

Copy link

@andrewdryder andrewdryder Jan 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so couldn't we just log it to... debug? :)

Copy link

@MatthewRBruce MatthewRBruce Jan 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do that, fix up the grammar on it, but it looks more like it was used to just print some variables while Peter was working on it.

Copy link
Author

@pfryerdavis pfryerdavis Jan 11, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content really isn't important on it. If I recall, I didn't even use the log line in testing.

bus.replay(in, logPath.toString, !isCompleted, eventsFilter)
logInfo(s"Finished parsing $logPath")
}
Expand Down