Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event and service check metric type #122

Closed
wants to merge 2 commits into from
Closed

Conversation

fmejia97
Copy link
Contributor

This PR provides the same functionality as #109 , but without the refactor. The aim is to see if we can reduce the 16% performance hit from the previous PR.

@fmejia97 fmejia97 requested a review from wvanbergen May 17, 2018 17:56
@fmejia97 fmejia97 force-pushed the add-dd-event-metrics branch from 69f1743 to 395ad18 Compare May 17, 2018 18:03
@fmejia97
Copy link
Contributor Author

fmejia97 commented May 17, 2018

Benchmarking results

TLDR; Performance hit is now 42%

Results for code with NEW changes

increment metric benchmark
                        16.548k i/100ms
measure metric benchmark
                        13.180k i/100ms
gauge metric benchmark
                        17.076k i/100ms
set metric benchmark    13.505k i/100ms
Calculating -------------------------------------
increment metric benchmark
                        193.313k (±10.6%) i/s -    959.784k in   5.031107s
measure metric benchmark
                        159.501k (± 8.0%) i/s -    803.980k in   5.073448s
gauge metric benchmark
                        222.199k (± 4.9%) i/s -      1.110M in   5.007758s
set metric benchmark    145.680k (± 9.2%) i/s -    729.270k in   5.047882s 

Results for current master

Warming up --------------------------------------
increment metric benchmark
                        28.004k i/100ms
measure metric benchmark
                        21.855k i/100ms
gauge metric benchmark
                        29.549k i/100ms
set metric benchmark    20.899k i/100ms
Calculating -------------------------------------
increment metric benchmark
                        283.951k (± 8.9%) i/s -      1.428M in   5.067626s
measure metric benchmark
                        231.504k (± 6.1%) i/s -      1.158M in   5.022373s
gauge metric benchmark
                        303.683k (± 8.0%) i/s -      1.537M in   5.092620s
set metric benchmark    200.402k (± 9.9%) i/s -      1.003M in   5.065671s

@fmejia97 fmejia97 requested a review from maximebedard May 17, 2018 18:07
@wvanbergen wvanbergen closed this Sep 27, 2019
@wvanbergen wvanbergen deleted the add-dd-event-metrics branch September 27, 2019 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants