Refactor Command classes to make run method the public API
#1577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By making the abstract `execute` method be a private method, we can ensure that all commands are invoked via the `run` method, which allows us to wrap them in `Tapioca.silence_warnings` today and potentially do more in the future.
Morriar
reviewed
Jul 21, 2023
Morriar
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Finally getting around to #1218 (review) comment by @Morriar.
By making the abstract
executemethod be a private method, we can ensure that all commands are invoked via therunmethod, which allows us to wrap them inTapioca.silence_warningstoday and potentially do more in the future.Implementation
Add
Command#runmethod that callsCommand#executeand makeCommand#executea private method. Encapsulate allTapioca.silence_warningscalls.Tests
There should be no behaviour change.