Add compiler for ActiveRecord::Store #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramgre
force-pushed
the
activerecord-store
branch
2 times, most recently
from
840ac69
to
352b225
Compare
|
I have signed the CLA! |
|
Thanks. I can merge once it's rebased on main. |
aramgre
force-pushed
the
activerecord-store
branch
from
352b225
to
dd2b079
Compare
|
Thanks @KaanOzkan, it's rebased |
KaanOzkan
force-pushed
the
activerecord-store
branch
from
dd2b079
to
80f8fb7
Compare
|
I did a force push because the rebase removed a test expectation. |
|
Sorry about that rebase fail, thanks for fixing it @KaanOzkan 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Adds a DSL compiler for methods generated by ActiveRecord::Store.
Implementation
ActiveRecord:Storedoes not save the prefix or suffix options after defining accessors, so this PR overridesstore_accessor, which is also called indirectly bystore, to capture them.Tests
Added