Update the workaround for debug gem
#1723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current approach of disabling `debug` loading makes it impossible to debug Tapioca itself with the gem. But by lazily activate the debugger, we can avoid the side-effect as well as allowing breakpoints to lazily load the debugger. It's the same as doing `require "debug/prelude"`, which only defines the breakpoint methods.
Morriar
approved these changes
Nov 29, 2023
|
Thank you ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current approach of disabling
debugloading makes it impossible to debug Tapioca itself with the gem.Implementation
But by lazily activate the debugger, we can avoid the side-effect as well as allowing breakpoints to lazily load the debugger.
It's the same as doing
require "debug/prelude", which only defines the breakpoint methods.Tests