Use Prism to determine valid names #2060
Merged
+13
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
force-pushed
the
vs-use-prism-to-determine-valid-names
branch
from
e62913d
to
04233fd
Compare
andyw8
reviewed
Oct 30, 2024
amomchilov
approved these changes
Oct 30, 2024
| op == :definemethod && arg == name.to_sym | ||
| rescue SyntaxError | ||
| false | ||
| # Special case: Prism supports parsing `def @foo; end`, but the Sorbet parser doesn't. This condition can go away |
There was a problem hiding this comment.
Prism supports parsing
def @foo; end
Is that a bug?
There was a problem hiding this comment.
I'm not sure if Prism should be rejecting this syntax or not. @kddnewton thoughts?
There was a problem hiding this comment.
Oh that's definitely a bug.
Morriar
reviewed
Oct 30, 2024
paracycle
reviewed
Oct 30, 2024
| # once Sorbet is using Prism under the hood as it will no longer result in an RBI that Sorbet can't parse | ||
| return false if name.start_with?("@") | ||
|
|
||
| result = Prism.parse("def #{name}(a); end") |
There was a problem hiding this comment.
Why not test Prism.parse("def self.#{name}(a); end") instead? I think it would address both the @foo concern and the self.foo one with just the parse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While hunting for memory optimizations, I noticed that a lot of memory was being retained by
RubyVM::InstructionSequence. The only place in Tapioca where we use this is to determine if method or parameter names are valid to avoid generating incorrect RBIs.We can ditch this internal API and rely on Prism to achieve the same, which won't retain memory and is actually faster.
Implementation
Switched to using Prism for determining if a method/parameter name is valid. I benchmarked the current approach vs the one on this branch and these were the results:
Tests
Current tests should cover it.