Allow disabling the "This file is generated header" with --no-header
#389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful when the generated file is used in a central repository such as `sorbet=-typed` and meant to be augmented manually by a human. Closes Shopify/team-ruby-dx#426. Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
KaanOzkan
approved these changes
Jul 15, 2021
vinistock
approved these changes
Jul 15, 2021
rafaelfranca
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is useful when the generated file is used in a central repository such as
sorbet=-typedand meant to be augmented manually by a human.
Implementation
Added a config option for
file-headerand hijacked therbi_headermethod.Tests
See automated tests.
Closes https://github.com/Shopify/sorbet-issues/issues/426.