Add ActiveStorage getter and setter generator for has_one_attached and has_many_attached #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You'll have to run |
paracycle
requested changes
Aug 7, 2021
mojanjz
force-pushed
the
mojan-activestorage-generator
branch
from
24f71ee
to
50941eb
Compare
mojanjz
commented
Aug 10, 2021
mojanjz
force-pushed
the
mojan-activestorage-generator
branch
4 times, most recently
from
25a9c65
to
4eeea3d
Compare
mojanjz
commented
Aug 10, 2021
|
|
||
| require "active_storage/engine" | ||
|
|
||
| class Dummy < Rails::Application |
There was a problem hiding this comment.
creating a dummy app to run all Rails initializer to load all ActiveStorage classes.
paracycle
requested changes
Aug 10, 2021
mojanjz
force-pushed
the
mojan-activestorage-generator
branch
from
203cdca
to
944997e
Compare
mojanjz
force-pushed
the
mojan-activestorage-generator
branch
from
944997e
to
001a27c
Compare
mojanjz
commented
Aug 11, 2021
| ) | ||
| scope.create_method( | ||
| "#{name}=", | ||
| parameters: [create_param("attachable", type: "T.untyped")], |
There was a problem hiding this comment.
it seems like attachable can be any of the types mentioned here
paracycle
reviewed
Aug 11, 2021
paracycle
reviewed
Aug 11, 2021
paracycle
approved these changes
Aug 12, 2021
Morriar
reviewed
Aug 12, 2021
Morriar
reviewed
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
closes #376
Based on ActiveStorage documentation on
has_one_attachedandhas_many_attached, we are missing getter/setter methods for the attachments.Here is the source code for these getters and setters:
has_one_attachedandhas_many_attached. The other methods are picked up byActiveRecordscope and association generators.Implementation
Added an
ActiveStoragegenerator that adds the getter and setter methods for the attachments to theActiveRecordmodel.Added tests for ActiveStorage associations and scopes to
active_record_associations_specandactive_record_scope_spec. I put the tests in a newdescribeblock, but if there is a more acceptable way to do this let me know.Tests
Added tests for the generator