The doc option should not have a default value
#566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The actual base default value of our flags is set in the `ConfigBuilder` class. Any value passed to the command line flags (even if it is a default value) will override all the values in the default and in the config. The upshot is that, since we had the default value of `false` for the `doc` option, a `doc: true` addition to the config file had no effect since the `false` coming from options would always override the config one.
vinistock
approved these changes
Oct 27, 2021
KaanOzkan
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The actual base default value of our flags is set in the
ConfigBuilderclass. Any value passed to the command line flags (even if it is a default value) will override all the values in the default and in the config.The upshot is that, since we had the default value of
falsefor thedocoption, adoc: trueaddition to the config file had no effect since thefalsecoming from options would always override the config one.Implementation
Remove the default value.
Tests
No tests.