Fix eval'ed constants not being generated in gem RBI generation #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaanOzkan
approved these changes
Nov 3, 2021
mutecipher
approved these changes
Nov 3, 2021
For eval'ed classes/modules, the `path` attribute of the TracePoint object ends up being `"(eval)"`, which does not help us figure out where the class/module is being defined. Instead, we can look back up the call stack until we find the first caller location that has a `path` that is not equal to `"(eval)"` which is where the call is ultimately being made from.
paracycle
force-pushed
the
uk-fix-evaled-constants
branch
from
e70d720
to
2a1cc8a
Compare
vinistock
approved these changes
Nov 3, 2021
Morriar
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #537
Implementation
For
eval'ed classes/modules, thepathattribute of the TracePoint object ends up being"(eval)", which does not help us figure out where the class/module is being defined.Instead, we can look back up the call stack until we find the first caller location that has a
paththat is not equal to(eval)"which is where the call is ultimately being made from.Tests
Added a failing test that passes after the fix.