Add more safety chekc when creating blob

Shopify · Jan 19, 2022 · f0c8e99 · f0c8e99
1 parent 5f9cec8
commit f0c8e99
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/snapshot_creator.go b/snapshot_creator.go
@@ -73,6 +73,10 @@ func (s *SnapshotCreator) Create(functionCode FunctionCodeHandling) (*StartupDat
 		return nil, errors.New("v8go: Cannot use snapshot creator after creating the blob")
 	}
 
+	if s.ctx == nil {
+		return nil, errors.New("v8go: Cannot create a snapshot without first adding a context")
+	}
+
 	rtn := C.CreateBlob(s.ptr, s.ctx.ptr, C.int(functionCode))
 
 	s.ptr = nil

diff --git a/snapshot_creator_test.go b/snapshot_creator_test.go
@@ -82,3 +82,13 @@ func TestCreateSnapshotErrorAfterSuccessfullCreate(t *testing.T) {
 		t.Error("Creating snapshot should have fail")
 	}
 }
+
+func TestCreateSnapshotErrorIfNoContextIsAdded(t *testing.T) {
+	snapshotCreator := v8.NewSnapshotCreator()
+
+	_, err := snapshotCreator.Create(v8.FunctionCodeHandlingKlear)
+
+	if err == nil {
+		t.Error("Creating a snapshop should have fail")
+	}
+}