This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
OpenTelemetry metrics (and the rest of grafeas/voucher) #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dani Santos <daniele.santos@shopify.com>
Release v2.7.0 via GitHub Actions
logging: url as string
…text voucher_client: maintain context
ReferenceToProject: support Artifact Registry
We expect you to provide an otel-collector output, and we will speak http, https, grpc or insecure-grpc to that endpoint. There's an easy path to use providing scrape-able Prometheus metrics too, but that is not implemented! We do not let you provide certificate auth, which might be a thing for gRPC... I'm awkwardly reusing the `[statsd]` section of the config file - I didn't want to introduce a sibling `[stats]` section, but maybe this should all go into a `[otel]` section to avoid confusion? 🤷
rm clair support
stranded clair config
OpenTelemetry metrics
…ject Fallback build details project
thepwagner
requested review from
rxbchen and
lynnsh
and removed request for
a team
lynnsh
reviewed
Oct 20, 2022
lynnsh
approved these changes
Nov 17, 2022
| @@ -14,12 +14,7 @@ Make sure that you update the `ejson` or `sops` specific blocks to point to the | |||
|
|
|||
| ## Create secrets | |||
|
|
|||
| <<<<<<< HEAD | |||
| (Deprecated, clair is no longer supported) | |||
There was a problem hiding this comment.
Would we want to mention somewhere that clair is no longer supported?
There was a problem hiding this comment.
We were OK with removing the mention in grafeas#66 ; so I don't think it's a big issue.
I think it's easy enough to see this being removed - https://github.com/search?q=repo%3Agrafeas%2Fvoucher%20clair&type=code , I don't feel bad not leaving a not that a feature that nobody used is no longer supported 😆 .
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synchronize
Shopify/vouchertografeas/voucher:main.The driver for this change is getting grafeas#68 into the fork that Shopify uses.
I opted to implement that feature and merge
main, because once we action grafeas#47 , there is no longer a reason for Shopify to maintain a fork 🎉 .You should see two types of changes in this diff: