Replace byebug with debug for debugging
#364
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larouxn
force-pushed
the
replace_byebug_with_debug
branch
from
a665dc4 to
b992b67
Compare
larouxn
force-pushed
the
replace_byebug_with_debug
branch
2 times, most recently
from
72098e2 to
bd617a1
Compare
larouxn
force-pushed
the
replace_byebug_with_debug
branch
from
bd617a1 to
9b285a5
Compare
larouxn
force-pushed
the
replace_byebug_with_debug
branch
from
9b285a5 to
b6207a8
Compare
larouxn
force-pushed
the
replace_byebug_with_debug
branch
from
b6207a8 to
659cdff
Compare
larouxn
force-pushed
the
replace_byebug_with_debug
branch
from
659cdff to
b12a435
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Replace the use of
byebug(plusirbandreline) withdebugfor debugging.Follow up to #359 and #363 (currently contains both branches' commits)
What approach did you choose and why?
Cleaner, simpler, and more modern.
What should reviewers focus on?
Any reason we want to stick with byebug?
The impact of these changes
More standard Ruby codebase.
Testing
Testing debugging works while working on fixing these tests.
Checklist
Determined not necessary as it's a developer facing change, not user facing.