Vim8 support using nvim-yarp and vim-hug-neovim-rpc #553

Shougo · 2017-10-15T03:15:16Z

~~I have added the test code for nvim-yarp.~~
~~But it is freezed. Why?~~

@roxma

More Vim8 testers are needed.
Especially, Windows users.

Fix #339

Requirements:

https://github.com/roxma/nvim-yarp

https://github.com/roxma/vim-hug-neovim-rpc For Vim8

roxma · 2017-10-15T03:50:45Z

Is there a minimal vimrc?

It works on my side with this vimrc

set nocompatible
syntax on
filetype plugin indent on
set encoding=utf-8 fileencodings=ucs-bom,utf-8,gbk,gb18030,latin1 termencoding=utf-8

call plug#begin(expand('<sfile>:h') . '/plugged-deoplete/')
Plug 'Shougo/deoplete.nvim'
Plug 'roxma/vim-hug-neovim-rpc'
Plug 'roxma/nvim-yarp'
call plug#end()

After starting neovim, type :call deoplete#enable()

Then the keyword completion is working.

I also need reproducing steps to start with.

Shougo · 2017-10-15T03:57:44Z

Please test yarp branch.
The keyword completion should not work.
Because I have disabled the initialization.

roxma · 2017-10-15T03:59:57Z

[roxma@roxma-pc deoplete.nvim]$ gs
On branch yarp
nothing to commit, working tree clean
[roxma@roxma-pc deoplete.nvim]$ git log
commit b10d6b30c6e7cdc665c420f453b7cc0118c55f32 (grafted, HEAD -> yarp, shougo/yarp, origin/yarp)
Author: Shougo Matsushita <Shougo.Matsu@gmail.com>
Date:   Sun Oct 15 12:14:07 2017 +0900

    Test

I'm sure I'm on yarp branch.

I have called :call deoplete#enable() manually

roxma · 2017-10-15T04:03:42Z

Sorry,

Just noticed that I'm on the wrong working directory. I'll test it again.

roxma · 2017-10-15T04:26:56Z

Use this command for starting neovim, NVIM_PYTHON_LOG_FILE=nvim.log NVIM_PYTHON_LOG_LEVEL=DEBUG vim, it will generate log files for deoplete module, it's very helpful.

It works on my side after #554.

Shougo · 2017-10-15T07:15:27Z

I have merged your PR.

It seems works in the minimal vimrc.

Shougo · 2017-10-15T07:51:18Z

@roxma It does not work in Vim8. Can you test it?

roxma · 2017-10-15T07:57:40Z

This commit roxma@10b3b58 based on #554 woks on vim8

I cannot send a PR, since it requires manual merge with your latest commit.

Shougo · 2017-10-15T08:00:24Z

I have fixed the commit manually.
But it does not work for me in Vim8.

Shougo · 2017-10-15T08:04:26Z

neovim_rpc#serveraddr() seems works.

roxma · 2017-10-15T08:07:53Z

Could you test the exact commit of this fork roxma@10b3b58

I pulled your latest commit, but it does not work. It seems other part is not working.

Shougo · 2017-10-15T08:12:53Z

@roxma
I have get the following errors.

Error detected while processing function deoplete#enable[1]..deoplete#initialize[1]..deoplete#init#_initialize[9]..deoplete#init#_channel[9]..<SNR>26_notify[1]..1[4]..yarp#pyx#init[11]..yarp#_serveraddr[9]..neovim_rpc#serveraddr:
line    5:
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ModuleNotFoundError: No module named 'neovim_rpc_server'
line    6:
Traceback (most recent call last):
  File "<string>", line 1, in <module>
NameError: name 'neovim_rpc_server' is not defined
E858: Eval did not return a valid python object
line   11:
E475: Invalid argument:
line   17:
E906: not an open channel

roxma · 2017-10-15T08:15:47Z

vim-hug-neovim-rpc is not working

Update both yarp and vim-hug-neovim-rpc to the latest version

Then check the result of these commands

set pyxversion
python3 import neovim
python3 import neovim_rpc_server

python import neovim
python import neovim_rpc_server

echo neovim_rpc#serveraddr()

Shougo · 2017-10-15T08:21:29Z

I have updated both.
But it does not work.

roxma · 2017-10-15T08:22:38Z

What's the results of those commands?

Shougo · 2017-10-15T08:27:26Z

python3 import neovim does not work.

Messages maintainer: Bram Moolenaar <Bram@vim.org>
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/lib/python3.6/site-packages/neovim/__init__.py", line 11, in <module>
    from .msgpack_rpc import (ErrorResponse, child_session, socket_session,
  File "/usr/lib/python3.6/site-packages/neovim/msgpack_rpc/__init__.py", line 10, in <module>
    from .session import ErrorResponse, Session
  File "/usr/lib/python3.6/site-packages/neovim/msgpack_rpc/session.py", line 7, in <module>
    import greenlet
ImportError: /usr/lib/python3.6/site-packages/greenlet.cpython-36m-x86_64-linux-gnu.so: undefined symbol: PyExc_ValueError

roxma · 2017-10-15T08:28:29Z

If set pyxversion gets a 3, either make vim8 works with python3 import neovim or add set pyxversion=2 into your vimrc

With set pyxversion=2, you need to get :python import neovim work

Shougo · 2017-10-15T08:30:34Z

set pyxversion is 3, but it does not work...

AlexMasterov · 2017-10-16T09:24:16Z

@Shougo
I checked the Python $PATH using echo exepath('python3'), and he pointed to the third-party (msys2) python3 executable. This was fixed by specifying g:python3_host_prog. Now it seems to work for me.

Shougo · 2017-10-16T09:30:51Z

Thank you for your testing.
It seems vim-hug-neovim-rpc problem...

Shougo · 2017-10-16T09:31:07Z

I will add the problem in FAQ.

tracyone · 2017-10-16T13:11:36Z

macOS 10.13

vim version:8.0 1194

Work but it is a bit slow at startup.

Another problem is neovim. See following screenshot.

    Plug 'Shougo/deoplete.nvim'
    Plug 'zchee/deoplete-clang'
    if !te#env#IsNvim()
        Plug 'roxma/nvim-yarp'
        Plug 'roxma/vim-hug-neovim-rpc'
    endif

roxma · 2017-10-16T13:15:39Z

@tracyone

Plug 'Shougo/deoplete.nvim'
Plug 'zchee/deoplete-clang'
Plug 'roxma/nvim-yarp'
if !te#env#IsNvim()
    Plug 'roxma/vim-hug-neovim-rpc'
endif

Move yarp out of the if block

Shougo · 2017-10-16T14:23:59Z

@tracyone Please read the error messages...

Shougo · 2017-10-16T14:35:08Z

I have added Python3 detection.

markonm · 2017-10-18T18:12:22Z

@roxma
Is it necessary to have Plug 'roxma/vim-hug-neovim-rpc' inside if block? Isn't it loaded only on demand because it only contains autoload folder?

Shougo · 2017-10-18T23:27:36Z

@xtal8 vim-hug-neovim-rpc is needed for Vim.
nvim-yarp is needed for both Vim and neovim.

wsdjeg · 2017-10-19T07:42:19Z

@Shougo IN old version, deoplete do not need vim-yarp by default in Neovim. I think we should keep this behavior！

many people use Neovim only. and some old user of deoplete do not install vim-yarp.

Shougo · 2017-10-19T07:57:14Z

@Shougo IN old version, deoplete do not need vim-yarp by default in Neovim. I think we should keep this behavior！

many people use Neovim only. and some old user of deoplete do not install vim-yarp.

Of course, I have thought the problem.
I don't like the dependency.

Shougo · 2017-10-19T07:58:05Z

But we have many :UpdateRemotePlugins issues.

https://github.com/Shougo/deoplete.nvim/issues?q=is%3Aissue+updateremoteplugins+is%3Aclosed

This is annoying.

wsdjeg · 2017-10-19T08:06:14Z

@Shougo this kind issues should be fixed by neovim itself instead of plugin. I am not sure if there is any PR about it.

Shougo · 2017-10-19T08:07:13Z

And I don't want to keep neovim code and Vim8 code.

@Shougo this kind issues should be fixed by neovim itself instead of plugin. I am not sure if there is any PR about it.

Yes, and it is not fixed yet!

wsdjeg · 2017-10-19T08:10:12Z

hmm. ok I got it.

Shougo · 2017-10-19T08:37:51Z

OK. I will consider the problem.

Shougo · 2017-10-19T08:39:29Z

The merge needs more time.
Please wait.

Shougo · 2017-10-21T04:31:49Z

I have fixed the compatibility problems.

@wsdjeg Please test it.

Shougo · 2017-10-22T02:10:56Z

Merged.

wsdjeg · 2017-10-22T02:14:06Z

nice work！

mreishus · 2017-11-15T17:24:10Z

Great job. It's working for me in windows with vim 8.

Here are my notes on getting the python support in vim to work on windows if anyone googling finds this:

" 0. Install chocolately package manager.
" 1. If you installed vim on your own, uninstall it and run "choco install vim".
" 1.5.  The choco version of vim is installed with dynamic python support, so you only need to have a python35.dll in your path.  Note that later versions of the choco vim package may bump this to 3.6, and later steps will need to be modified.
" 2. choco install python3 --version 3.5.4
" 3. choco pin add -n=python3 --version 3.5.4
" 4. Add C:\python35 to path and run refreshenv in powershell
" 5. Copy C:\Python35\python.exe to C:\Python35\python3.exe 
" 6. C:\Python35\Scripts\pip.exe install neovim

Test

b10d6b3

Shougo mentioned this pull request Oct 15, 2017

Any plan to porting Deoplete to Vim 8? #339

Closed

fix missing argument error

bf1971c

roxma mentioned this pull request Oct 15, 2017

fix missing argument error #554

Merged

Use nvim-yarp plugin

f91bff7

Shougo force-pushed the yarp branch from f2cd692 to f91bff7 Compare October 15, 2017 07:30

Fix errors

be0777b

Shougo added 2 commits October 15, 2017 16:57

Update the requirements

b2a73c4

Update .gitignore

79da696

Shougo added 2 commits October 15, 2017 17:08

Fix pytest error

5a2d8a9

Fix logging

dd058f5

Fix

238fb29

Update the documentation

b3612dd

Add Python3 detection

31051cc

Shougo added 2 commits October 19, 2017 08:17

Update ISSUE_TEMPLATE

a8d22e1

Improve the error checks

9aae2be

Shougo added 3 commits October 21, 2017 12:09

Update the documentation

7662bae

Improve the notify behavior

967f8b4

Fix the compatibility problems in Vim8/Neovim

0039ab2

Shougo merged commit 1f074c1 into master Oct 22, 2017

Shougo deleted the yarp branch October 22, 2017 02:10

Vim8 support using nvim-yarp and vim-hug-neovim-rpc #553

Vim8 support using nvim-yarp and vim-hug-neovim-rpc #553

Conversation

Shougo commented Oct 15, 2017 • edited Loading

roxma commented Oct 15, 2017 • edited Loading

Shougo commented Oct 15, 2017

roxma commented Oct 15, 2017

roxma commented Oct 15, 2017

roxma commented Oct 15, 2017 • edited Loading

Shougo commented Oct 15, 2017 • edited Loading

Shougo commented Oct 15, 2017

roxma commented Oct 15, 2017

Shougo commented Oct 15, 2017 • edited Loading

Shougo commented Oct 15, 2017

roxma commented Oct 15, 2017

Shougo commented Oct 15, 2017

roxma commented Oct 15, 2017

Shougo commented Oct 15, 2017

roxma commented Oct 15, 2017

Shougo commented Oct 15, 2017

roxma commented Oct 15, 2017 • edited Loading

Shougo commented Oct 15, 2017

AlexMasterov commented Oct 16, 2017

Shougo commented Oct 16, 2017

Shougo commented Oct 16, 2017

tracyone commented Oct 16, 2017

roxma commented Oct 16, 2017

Shougo commented Oct 16, 2017

Shougo commented Oct 16, 2017

markonm commented Oct 18, 2017

Shougo commented Oct 18, 2017

wsdjeg commented Oct 19, 2017

Shougo commented Oct 19, 2017 • edited Loading

Shougo commented Oct 19, 2017

wsdjeg commented Oct 19, 2017

Shougo commented Oct 19, 2017

wsdjeg commented Oct 19, 2017

Shougo commented Oct 19, 2017

Shougo commented Oct 19, 2017

Shougo commented Oct 21, 2017

Shougo commented Oct 22, 2017

wsdjeg commented Oct 22, 2017

mreishus commented Nov 15, 2017

Shougo commented Oct 15, 2017 •

edited

Loading

roxma commented Oct 15, 2017 •

edited

Loading

roxma commented Oct 15, 2017 •

edited

Loading

Shougo commented Oct 15, 2017 •

edited

Loading

Shougo commented Oct 15, 2017 •

edited

Loading

roxma commented Oct 15, 2017 •

edited

Loading

Shougo commented Oct 19, 2017 •

edited

Loading