Support WebGL1 context #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see https://developer.mozilla.org/en-US/docs/Web/API/WebGLRenderingContext/texSubImage2D This code converts incompatible sources (ImageData, HTMLCanvasElement, HTMLImageElement) to an ArrayBufferView that will work in WebGL1
ShukantPal
reviewed
Apr 16, 2023
ShukantPal
reviewed
Apr 16, 2023
ShukantPal
approved these changes
Apr 16, 2023
|
Thanks for your contribution! |
|
Published in @pixi-essentials/texture-allocator@2.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this library!
We found that some of the sources we were adding to the texture atlas weren't compatible with WebGL1 context, needed to support some of our users on older hardware.
This code converts incompatible sources (ImageData, HTMLCanvasElement, HTMLImageElement) to an ArrayBufferView that will work in WebGL1
see https://developer.mozilla.org/en-US/docs/Web/API/WebGLRenderingContext/texSubImage2D
re rapideditor/pixi-texture-allocator#1