Change default mac keybindings for play previous/next #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Released as 2.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Love this extension. It's a very neat idea. Unfortunately, I'm not as big of a fan of its default keybindings for
spotify.nextandspotify.pevious.On Mac, these bindings are
cmd+shift+]andcmd+shift+[respectively. These keybindings are quite universal as keybindings for cycling through tabs in basically all editors and browsers. At least in VSCode, there will be a conflict withworkbench.action.previousEditorandworkbench.action.nextEditor. It is very odd for me to change my normal software development habits due to this extensions's defaults, so I immediately found myself wanting to change the Spotify keymappings instead.My PR introduces what I find to be reasonable alternative defaults. I was not able to find other conflicting keymappings that matches
ctrl+cmd+[orctrl+cmd+]. It allows the square bracket characters to continue to be present in the keymappings, to directionally represent going forward or backwards in the playlist.I'm not sure if the Windows keymapping needs to be changed too. I don't have a Windows machine, so I could not check whether a conflict exists between these Spotify keymappings and VSCode default keymappings for Windows. I'll leave it up to the maintainers to determine if a change needs to happen for that OS.
I hope this helps.