Skip to content

Commit

Permalink
HBASE-27046 The filenum in AbstractFSWAL should be monotone increasing (
Browse files Browse the repository at this point in the history
apache#4449)

Signed-off-by: Xin Sun <ddupgs@gmail.com>
Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
  • Loading branch information
Apache9 authored Jun 2, 2022
1 parent d030040 commit 313a37f
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -630,12 +630,8 @@ public Path getCurrentFileName() {
* retrieve the next path to use for writing. Increments the internal filenum.
*/
private Path getNewPath() throws IOException {
this.filenum.set(EnvironmentEdgeManager.currentTime());
this.filenum.set(Math.max(getFilenum() + 1, EnvironmentEdgeManager.currentTime()));
Path newPath = getCurrentFileName();
while (fs.exists(newPath)) {
this.filenum.incrementAndGet();
newPath = getCurrentFileName();
}
return newPath;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,9 @@
import org.junit.AfterClass;
import org.junit.BeforeClass;
import org.junit.ClassRule;
import org.junit.Ignore;
import org.junit.Test;
import org.junit.experimental.categories.Category;

@Ignore // disable for now, see HBASE-27045
@Category({ RegionServerTests.class, LargeTests.class })
public class TestClusterScopeQuotaThrottle {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,11 @@
import org.junit.AfterClass;
import org.junit.BeforeClass;
import org.junit.ClassRule;
import org.junit.Ignore;
import org.junit.Test;
import org.junit.experimental.categories.Category;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

@Ignore // Disabled because flakey. Fails ~30% on a resource constrained GCE though not on Apache.
@Category({ RegionServerTests.class, MediumTests.class })
public class TestQuotaThrottle {

Expand Down

0 comments on commit 313a37f

Please sign in to comment.